🛡️ Sentinel: [HIGH] Fix command injection in toolExists#99
🛡️ Sentinel: [HIGH] Fix command injection in toolExists#99
Conversation
Replaced insecure shell wrapper execution using string interpolation with direct binary execution via Foundation.Process to prevent command injection. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: HIGH
💡 Vulnerability: The
toolExists(_:)method inSources/Cacheout/Models/CacheCategory.swiftpassed unsanitized user input (tool) to a shell wrapper via string interpolation (shell("/usr/bin/which \(tool)")). This is a classic command injection vulnerability.🎯 Impact: An attacker could execute arbitrary commands with the privileges of the application by supplying a crafted string (e.g.,
git; cat /etc/passwd) as thetoolargument.🔧 Fix: Replaced the insecure shell wrapper invocation with a direct invocation of
/usr/bin/whichusingFoundation.Process. The tool name is now safely passed as an isolated element in theprocess.argumentsarray, which prevents the shell from interpreting metacharacters. Also securely redirected standard streams toFileHandle.nullDevice.✅ Verification:
Processexecution logic locally../scripts/test.sh.PR created automatically by Jules for task 14739727403125208993 started by @acebytes